The following document contains the results of PMD 3.9.
| Violation | Line |
|---|---|
| Overridable method 'setBaseConfiguration' called during object construction | 71 |
| Parameter 'documentation' is not assigned and could be declared final | 74 |
| Parameter 'aSectionId' is not assigned and could be declared final | 79 |
| Parameter 'documentation' is not assigned and could be declared final | 79 |
| Local variable 'section' could be declared final | 83 |
| Found 'DU'-anomaly for variable 'aSettingId' (lines '88'-'95'). | 88 - 95 |
| Parameter 'aSectionId' is not assigned and could be declared final | 88 |
| Parameter 'aSettingId' is not assigned and could be declared final | 88 |
| Parameter 'documentation' is not assigned and could be declared final | 88 |
| Local variable 'section' could be declared final | 92 |
| Parameter 'aSectionId' is not assigned and could be declared final | 97 |
| Parameter 'newSetting' is not assigned and could be declared final | 97 |
| Local variable 'section' could be declared final | 101 |
| These nested if statements could be combined | 105 - 111 |
| Parameter 'newSectionId' is not assigned and could be declared final | 117 |
| These nested if statements could be combined | 123 - 129 |
| Deeply nested if..then statements are hard to read | 123 - 129 |
| Parameter 'obj' is not assigned and could be declared final | 137 |
| Local variable 'other' could be declared final | 141 |
| These nested if statements could be combined | 145 - 148 |
| Deeply nested if..then statements are hard to read | 145 - 148 |
| A method should have only one exit point, and that should be the last statement in the method | 147 |
| Parameter 'aSectionId' is not assigned and could be declared final | 165 |
| Parameter 'aSectionId' is not assigned and could be declared final | 170 |
| Parameter 'aSettingId' is not assigned and could be declared final | 170 |
| Parameter 'aSectionId' is not assigned and could be declared final | 180 |
| Parameter 'aSection' is not assigned and could be declared final | 211 |
| Parameter 'aSetting' is not assigned and could be declared final | 211 |
| A method should have only one exit point, and that should be the last statement in the method | 216 |
| An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 226 |
| Found 'DU'-anomaly for variable 'aSectionId' (lines '237'-'248'). | 237 - 248 |
| Parameter 'aSectionId' is not assigned and could be declared final | 237 |
| A method should have only one exit point, and that should be the last statement in the method | 243 |
| Found 'DD'-anomaly for variable 'result' (lines '254'-'255'). | 254 - 255 |
| Found 'DU'-anomaly for variable 'sectionId' (lines '263'-'274'). | 263 - 274 |
| Parameter 'sectionId' is not assigned and could be declared final | 263 |
| A method should have only one exit point, and that should be the last statement in the method | 269 |
| Parameter 'baseConfiguration' is not assigned and could be declared final | 276 |
| Parameter 'documentations' is not assigned and could be declared final | 281 |
| Parameter 'sections' is not assigned and could be declared final | 286 |
| Use explicit scoping instead of the default package private level | 295 - 321 |
| Found 'DU'-anomaly for variable 'settingId' (lines '295'-'321'). | 295 - 321 |
| Found 'DU'-anomaly for variable 'sectionId' (lines '295'-'321'). | 295 - 321 |
| Parameter 'sectionId' is not assigned and could be declared final | 295 |
| Parameter 'settingId' is not assigned and could be declared final | 295 |
| Found 'DD'-anomaly for variable 'selectedSection' (lines '297'-'303'). | 297 - 303 |
| Found 'DD'-anomaly for variable 'selectedSection' (lines '303'-'303'). | 303 |
| A method should have only one exit point, and that should be the last statement in the method | 309 |
| A method should have only one exit point, and that should be the last statement in the method | 316 |
| Violation | Line |
|---|---|
| Overridable method 'setLanguage' called during object construction | 43 |
| Overridable method 'setText' called during object construction | 44 |
| Parameter 'obj' is not assigned and could be declared final | 48 |
| Local variable 'other' could be declared final | 52 |
| These nested if statements could be combined | 56 - 59 |
| Deeply nested if..then statements are hard to read | 56 - 59 |
| A method should have only one exit point, and that should be the last statement in the method | 58 |
| Found 'DD'-anomaly for variable 'result' (lines '80'-'81'). | 80 - 81 |
| Parameter 'language' is not assigned and could be declared final | 86 |
| Parameter 'text' is not assigned and could be declared final | 91 |
| Violation | Line |
|---|---|
| Perhaps 'documentation' could be replaced by a local variable. | 34 |
| Overridable method 'setId' called during object construction | 49 |
| Overridable method 'setSettings' called during object construction | 50 |
| Use explicit scoping instead of the default package private level | 53 - 58 |
| Parameter 'documentation' is not assigned and could be declared final | 53 |
| Use explicit scoping instead of the default package private level | 60 - 71 |
| Parameter 'newSetting' is not assigned and could be declared final | 60 |
| Parameter 'obj' is not assigned and could be declared final | 74 |
| Local variable 'other' could be declared final | 78 |
| These nested if statements could be combined | 82 - 85 |
| Deeply nested if..then statements are hard to read | 82 - 85 |
| A method should have only one exit point, and that should be the last statement in the method | 84 |
| Use explicit scoping instead of the default package private level | 92 - 95 |
| Parameter 'aSettingId' is not assigned and could be declared final | 102 |
| Found 'DD'-anomaly for variable 'result' (lines '124'-'125'). | 124 - 125 |
| Parameter 'id' is not assigned and could be declared final | 130 |
| Use explicit scoping instead of the default package private level | 135 - 138 |
| Parameter 'settings' is not assigned and could be declared final | 135 |
| Found 'DU'-anomaly for variable 'settingId' (lines '143'-'154'). | 143 - 154 |
| Parameter 'settingId' is not assigned and could be declared final | 143 |
| A method should have only one exit point, and that should be the last statement in the method | 149 |
| Violation | Line |
|---|---|
| Perhaps 'documentation' could be replaced by a local variable. | 39 |
| Overridable method 'setType' called during object construction | 65 |
| Overridable method 'setValue' called during object construction | 66 |
| Use explicit scoping instead of the default package private level | 69 - 74 |
| Parameter 'documentation' is not assigned and could be declared final | 69 |
| Parameter 'obj' is not assigned and could be declared final | 77 |
| Local variable 'other' could be declared final | 81 |
| These nested if statements could be combined | 85 - 91 |
| Deeply nested if..then statements are hard to read | 85 - 91 |
| These nested if statements could be combined | 87 - 90 |
| A method should have only one exit point, and that should be the last statement in the method | 89 |
| When instantiating a SimpleDateFormat object, specify a Locale | 123 |
| Local variable 'dateFormat' could be declared final | 123 |
| Use explicit scoping instead of the default package private level | 134 - 137 |
| Found 'DD'-anomaly for variable 'result' (lines '214'-'215'). | 214 - 215 |
| Parameter 'type' is not assigned and could be declared final | 221 |
| Parameter 'value' is not assigned and could be declared final | 226 |
| Violation | Line |
|---|---|
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 16 - 268 |
| Each class should declare at least one constructor | 25 - 268 |
| When instantiating a SimpleDateFormat object, specify a Locale | 27 |
| Parameter 'value' is not assigned and could be declared final | 29 |
| Parameter 'type' is not assigned and could be declared final | 29 |
| A method should have only one exit point, and that should be the last statement in the method | 33 |
| A method should have only one exit point, and that should be the last statement in the method | 38 |
| A method should have only one exit point, and that should be the last statement in the method | 43 |
| A method should have only one exit point, and that should be the last statement in the method | 48 |
| A method should have only one exit point, and that should be the last statement in the method | 53 |
| A method should have only one exit point, and that should be the last statement in the method | 58 |
| Parameter 'value' is not assigned and could be declared final | 72 |
| Parameter 'type' is not assigned and could be declared final | 72 |
| Local variable 'booleanValue' could be declared final | 82 |
| A method should have only one exit point, and that should be the last statement in the method | 84 |
| Local variable 'stringValue' could be declared final | 88 |
| Position literals first in String comparisons | 90 |
| Position literals first in String comparisons | 91 |
| A method should have only one exit point, and that should be the last statement in the method | 93 |
| Position literals first in String comparisons | 95 |
| Position literals first in String comparisons | 96 |
| Parameter 'value' is not assigned and could be declared final | 105 |
| Parameter 'type' is not assigned and could be declared final | 105 |
| Local variable 'dateValue' could be declared final | 115 |
| A method should have only one exit point, and that should be the last statement in the method | 117 |
| Static DateFormatter objects should be accessed in a synchronized manner | 117 |
| Local variable 'stringValue' could be declared final | 121 |
| Static DateFormatter objects should be accessed in a synchronized manner | 125 |
| Caught exception is rethrown, original stack trace may be lost | 129 - 132 |
| Parameter 'value' is not assigned and could be declared final | 144 |
| Parameter 'type' is not assigned and could be declared final | 144 |
| Local variable 'doubleValue' could be declared final | 153 |
| A method should have only one exit point, and that should be the last statement in the method | 155 |
| Local variable 'stringValue' could be declared final | 159 |
| Caught exception is rethrown, original stack trace may be lost | 166 - 169 |
| Parameter 'value' is not assigned and could be declared final | 181 |
| Parameter 'type' is not assigned and could be declared final | 181 |
| Local variable 'integerValue' could be declared final | 190 |
| A method should have only one exit point, and that should be the last statement in the method | 192 |
| Local variable 'stringValue' could be declared final | 196 |
| Caught exception is rethrown, original stack trace may be lost | 203 - 206 |
| Parameter 'values' is not assigned and could be declared final | 218 |
| Parameter 'type' is not assigned and could be declared final | 218 |
| Local variable 'arrayStringValue' could be declared final | 227 |
| Local variable 'builder' could be declared final | 228 |
| A method should have only one exit point, and that should be the last statement in the method | 236 |
| Local variable 'stringValue' could be declared final | 240 |
| Parameter 'value' is not assigned and could be declared final | 259 |
| Parameter 'type' is not assigned and could be declared final | 259 |
