PMD Results

The following document contains the results of PMD 3.9.

Files

org/limmen/crs/storage/xml/ConfigurationXMLReader.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.16 - 207
Each class should declare at least one constructor37 - 207
Found 'DU'-anomaly for variable 'resolver' (lines '39'-'74').39 - 74
Parameter 'rootNode' is not assigned and could be declared final39
Parameter 'resolver' is not assigned and could be declared final39
Local variable 'idNode' could be declared final41
Local variable 'configuration' could be declared final43
Local variable 'nodeList' could be declared final45
Local variable 'node' could be declared final49
Parameter 'rootNode' is not assigned and could be declared final76
Local variable 'documentation' could be declared final78
Local variable 'langNode' could be declared final80
Found 'DU'-anomaly for variable 'configuration' (lines '88'-'113').88 - 113
Parameter 'rootNode' is not assigned and could be declared final88
Parameter 'configuration' is not assigned and could be declared final88
Local variable 'idNode' could be declared final90
Found 'DU'-anomaly for variable 'sectionId' (lines '92'-'113').92 - 113
Local variable 'sectionId' could be declared final92
Local variable 'nodeList' could be declared final94
Local variable 'node' could be declared final98
Found 'DU'-anomaly for variable 'aSectionId' (lines '115'-'150').115 - 150
Found 'DU'-anomaly for variable 'configuration' (lines '115'-'150').115 - 150
Parameter 'aSectionId' is not assigned and could be declared final115
Parameter 'rootNode' is not assigned and could be declared final115
Parameter 'configuration' is not assigned and could be declared final115
Local variable 'idNode' could be declared final117
Local variable 'setting' could be declared final119
Local variable 'nodeList' could be declared final121
Local variable 'node' could be declared final125
Parameter 'aConfigurationFile' is not assigned and could be declared final152
Parameter 'resolver' is not assigned and could be declared final152
Found 'DD'-anomaly for variable 'fileInputStream' (lines '154'-'158').154 - 158
Avoid empty catch blocks168 - 171
Parameter 'inputStream' is not assigned and could be declared final175
Parameter 'resolver' is not assigned and could be declared final175
Local variable 'factory' could be declared final177
Found 'DD'-anomaly for variable 'builder' (lines '178'-'182').178 - 182
Found 'DD'-anomaly for variable 'document' (lines '189'-'193').189 - 193
Parameter 'aConfigurationFile' is not assigned and could be declared final203
Parameter 'resolver' is not assigned and could be declared final203

org/limmen/crs/storage/xml/ConfigurationXMLStorage.java

ViolationLine
Local variable 'stringBuffer' could be declared final39
Parameter 'configuration' is not assigned and could be declared final49
Parameter 'aConfigurationId' is not assigned and could be declared final54
Local variable 'sb' could be declared final56
Parameter 'configurationId' is not assigned and could be declared final64
Local variable 'fileForDeletion' could be declared final66
Local variable 'root' could be declared final74
Found 'DU'-anomaly for variable 'fileList' (lines '76'-'103').76 - 103
Found 'DU'-anomaly for variable 'fileList' (lines '76'-'103').76 - 103
Local variable 'fileList' could be declared final76 - 90
Avoid unnecessary if..then..else statements when returning a boolean81 - 88
Local variable 'listOfFiles' could be declared final92
Parameter 'configurationId' is not assigned and could be declared final106
Parameter 'configurationId' is not assigned and could be declared final118
A method should have only one exit point, and that should be the last statement in the method122
Parameter 'configuration' is not assigned and could be declared final134

org/limmen/crs/storage/xml/ConfigurationXMLWriter.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.16 - 228
Each class should declare at least one constructor44 - 228
Parameter 'aFile' is not assigned and could be declared final46
Parameter 'aConfiguration' is not assigned and could be declared final46
Found 'DD'-anomaly for variable 'fileOutputStream' (lines '48'-'52').48 - 52
Avoid empty catch blocks62 - 65
Parameter 'outputStream' is not assigned and could be declared final69
Parameter 'aConfiguration' is not assigned and could be declared final69
Local variable 'factory' could be declared final71
Found 'DD'-anomaly for variable 'builder' (lines '72'-'76').72 - 76
Local variable 'document' could be declared final83
Local variable 'configElement' could be declared final85
Avoid if (x != y) ..; else ..;91 - 104
Local variable 'baseConfig' could be declared final93
Avoid empty if statements101 - 104
Found 'DD'-anomaly for variable 'transformer' (lines '115'-'119').115 - 119
Local variable 'result' could be declared final135
Local variable 'source' could be declared final136
Parameter 'aFile' is not assigned and could be declared final148
Parameter 'aConfiguration' is not assigned and could be declared final148
Found 'DU'-anomaly for variable 'document' (lines '153'-'166').153 - 166
Found 'DU'-anomaly for variable 'root' (lines '153'-'166').153 - 166
Parameter 'document' is not assigned and could be declared final153
Parameter 'root' is not assigned and could be declared final153
Parameter 'documentation' is not assigned and could be declared final153
Local variable 'docNode' could be declared final157
Found 'DU'-anomaly for variable 'document' (lines '168'-'189').168 - 189
Found 'DU'-anomaly for variable 'root' (lines '168'-'189').168 - 189
Parameter 'document' is not assigned and could be declared final168
Parameter 'root' is not assigned and could be declared final168
Parameter 'aConfiguration' is not assigned and could be declared final168
Local variable 'sectionNode' could be declared final172
Found 'DU'-anomaly for variable 'document' (lines '191'-'227').191 - 227
Found 'DU'-anomaly for variable 'root' (lines '191'-'227').191 - 227
Parameter 'aSectionId' is not assigned and could be declared final191
Parameter 'document' is not assigned and could be declared final191
Parameter 'root' is not assigned and could be declared final191
Parameter 'aConfiguration' is not assigned and could be declared final191
Local variable 'settingNode' could be declared final197
Local variable 'valueNode' could be declared final210
Local variable 'typeNode' could be declared final215